On Sat, 2006-05-13 at 01:38 +0200, karl wettin wrote: > here are my comments.
It seems to run fine on Lists. But I have only been running it on an issue 550 index, so I have no idea how the Directory implementation index will take it. No test case, no nothing. Just tried it in live environment for a couple of minutes. > > > > StandardTokenizer: > > private java.util.Vector jj_expentries > > If the standard analyzer is not thread safe, does this make sense? Looks > genereted in my eyes. Did not look at the code. > > > > > Document: > > List fields = new Vector(); > > ArrayList. People don't add fields from multiple threads? > > > IndexWriter: > > addIndexes(IndexReader[]) > > Vector segmentsToDelete > > deleteFiles(Vector) > > Vector deletable > > deleteSegments(Vector) > > Vector deletable > > mergeSegments(int, int) > > Vector segmentsToDelete > > readDeleteableFiles() > > Vector results > > Located in methods. Vector makes no sense at all? > > > > > SegmentMerger: > > private Vector readers > > The IndexWriter keeps this instance synchronized? > > > > > TermVectorWriter: > > terms = new Vector(); > > The IndexWriter keeps this instance synchronized? > > > > > MultiFieldQueryParser: > > get(AnyKindOf)Query > > Vector clauses > > > In methods. Vector makes no sense? Query parser is not thread safe, does > this have to be? > > > > > QueryParser: > > private java.util.Vector jj_expentries > > Query(String) > > Vector caluses > > getFieldQuery(String, String) > > Vector v; // tokens from stream > > > In methods. Vector makes no sense? Query parser is not thread safe, does > this have to be? > > > BooleanQuery: > > private Vector clauses > > People don't build a query from multiple threads? > > > > > BooleanQuery.BooleanWeight: > > private Vector weights > > People don't build a query from multiple threads? > > > Hits: > > private Vector hitDocs > > Parallel hits collection might require this? > > > MultiPhraseQuery: > > private Vector positions > > Unsure. > > > PhraseQuery: > > private Vector positions > > private Vector terms > > People don't build a query from multiple threads? > > > > RAMFile: > > private Vector buffers > > The IndexWriter keeps this instance synchronized? > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
