I was assuming it would be changed so that LazyField extended Field. Is this not a better approach?
Fieldable sounds poor to me - implies an object can be a Field. If we are only working with fields, why not just extend Field, and remove Fieldable? -----Original Message----- From: Chris Hostetter [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 21, 2006 3:32 PM To: java-dev@lucene.apache.org; [EMAIL PROTECTED] Subject: RE: [jira] Commented: (LUCENE-609) Lazy field loading breaks backward compat : Would it not be easier to just create a LazyDocument that extends Document, : and handles all of this transparently? It would also require no changes to : existing code. : : The code that currently returns a Document, can just return a LazyDocument : (if lazy/selective loading is enabled). assuming you mean revert the return type of Document.getField back to "Field" and then LazyDocument as a subclass of Document; LazyDocument.getField would still need to be declared to return "Field" and that's the reason why the Fieldable interface was added: because LazyField doesn't extend Field. : -----Original Message----- : From: Yonik Seeley (JIRA) [mailto:[EMAIL PROTECTED] : Sent: Wednesday, June 21, 2006 2:29 PM : To: java-dev@lucene.apache.org : Subject: [jira] Commented: (LUCENE-609) Lazy field loading breaks backward : compat : : [ : http://issues.apache.org/jira/browse/LUCENE-609?page=comments#action_1241716 : 4 ] : : Yonik Seeley commented on LUCENE-609: : ------------------------------------- : : I just verified that Solr now compiles/works correctly again with this : patch. : Any objections to committing it? : : : > Lazy field loading breaks backward compat : > ----------------------------------------- : > : > Key: LUCENE-609 : > URL: http://issues.apache.org/jira/browse/LUCENE-609 : > Project: Lucene - Java : > Type: Bug : : > Components: Other : > Versions: 2.0.1 : > Reporter: Yonik Seeley : > Fix For: 2.0.1 : > Attachments: fieldable_patch.diff : > : > Document.getField() and Document.getFields() have changed in a non : backward compatible manner. : > Simple code like the following no longer compiles: : > Field x = mydoc.getField("x"); : : -- : This message is automatically generated by JIRA. : - : If you think it was sent incorrectly contact one of the administrators: : http://issues.apache.org/jira/secure/Administrators.jspa : - : For more information on JIRA, see: : http://www.atlassian.com/software/jira : : : --------------------------------------------------------------------- : To unsubscribe, e-mail: [EMAIL PROTECTED] : For additional commands, e-mail: [EMAIL PROTECTED] : : : --------------------------------------------------------------------- : To unsubscribe, e-mail: [EMAIL PROTECTED] : For additional commands, e-mail: [EMAIL PROTECTED] : -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
