[ 
http://issues.apache.org/jira/browse/LUCENE-365?page=comments#action_12443194 ] 
            
Paul Elschot commented on LUCENE-365:
-------------------------------------

That was indeed not intentional, thanks for adding it back.

To my surprise the svn update applied cleanly on
DisjunctionSumScorer.java here, and these tests still pass here:

ant -Dtestcase="TestBool*" test
ant -Dtestcase="TestDis*" test


> [PATCH] Performance improvement to DisjunctionSumScorer
> -------------------------------------------------------
>
>                 Key: LUCENE-365
>                 URL: http://issues.apache.org/jira/browse/LUCENE-365
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: CVS Nightly - Specify date in submission
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Paul Elschot
>         Assigned To: Yonik Seeley
>             Fix For: 2.1
>
>         Attachments: BooleanScorerBtree.java, DisjunctionSumScorer.java, 
> DisjunctionSumScorer20061017.patch, ScorerDocQueue.java, 
> TestDisjunctionPerf1.java
>
>
> A recent profile of the new BooleanScorer2 showed that 
> quite a bit of CPU time is spent in the advanceAfterCurrent method 
> of DisjunctionScorer, and in the PriorityQueue of scorers that 
> is used there. 
>  
> This patch reduces the internal overhead of DisjunctionScorer 
> to about 70% of the current one (ie. 30% saving in cpu time). 
> It also reduces the number of calls to the subscorers, but 
> that was not measured. 
>  
> To get this, it was necessary to specialize the PriorityQueue 
> for a Scorer and to add move some code fragments from DisjunctionScorer 
> to this specialized queue.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to