[ http://issues.apache.org/jira/browse/LUCENE-669?page=all ]
Otis Gospodnetic updated LUCENE-669:
------------------------------------
Lucene Fields: [Patch Available]
Looks fine to me.
Maybe change this a bit:
public void close() throws IOException {
- if (!isClone)
- file.close();
+ if (!isClone) {
+ if (file != null) {
+ file.close();
+ file = null;
+ }
+ }
}
That if (file != null) block could be replaced with closeFile() call, I think.
Also, what was closing the file when you run this in Eclipse?
> finalize()-methods of FSDirectory.FSIndexInput and FSDirectory.FSIndexOutput
> try to close already closed file
> -------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-669
> URL: http://issues.apache.org/jira/browse/LUCENE-669
> Project: Lucene - Java
> Issue Type: Bug
> Components: Store
> Reporter: Michael Busch
> Priority: Trivial
> Attachments: FSDirectory_close_file_patch.patch
>
>
> Hi all,
> I found a small problem in FSDirectory: The finalize()-methods of
> FSDirectory.FSIndexInput and FSDirectory.FSIndexOutput try to close the
> underlying file. This is not a problem unless the file has been closed before
> by calling the close() method. If it has been closed before, the finalize
> method throws an IOException saying that the file is already closed. Usually
> this IOException would go unnoticed, because the GarbageCollector, which
> calls finalize(), just eats it. However, if I use the Eclipse debugger the
> execution of my code will always be suspended when this exception is thrown.
> Even though this exception probably won't cause problems during normal
> execution of Lucene, the code becomes cleaner if we apply this small patch.
> Might this IOException also have a performance impact, if it is thrown very
> frequently?
> I attached the patch which applies cleanly on the current svn HEAD. All
> testcases pass and I verfied with the Eclipse debugger that the IOException
> is not longer thrown.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
