[
https://issues.apache.org/jira/browse/LUCENE-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464626
]
Michael McCandless commented on LUCENE-776:
-------------------------------------------
Karl, thanks for the offer, but we're still on JDK 1.4.x so far, so we
can't use that SoftReferenceMap<K,V> directly just yet (but it sounds
neat!).
Oh good point Nicolas. If we make this change it's actually a
semantic difference in the API in that previously you would get a
brand new FSDirectory but with this change you would get a "recycled"
one. I agree it's safer to not do this. I will update the comment to
remove the tantalizing reference to a WeakHashMap and then resolve.
Thanks!
> Use WeakHashMap instead of Hashtable in FSDirectory
> ---------------------------------------------------
>
> Key: LUCENE-776
> URL: https://issues.apache.org/jira/browse/LUCENE-776
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Nicolas Lalevée
> Assigned To: Michael McCandless
> Priority: Trivial
>
> I was just reading the FSDirectory java code, then I found this :
> /** This cache of directories ensures that there is a unique Directory
> * instance per path, so that synchronization on the Directory can be used
> to
> * synchronize access between readers and writers.
> *
> * This should be a WeakHashMap, so that entries can be GC'd, but that would
> * require Java 1.2. Instead we use refcounts...
> */
> private static final Hashtable DIRECTORIES = new Hashtable();
> Since Lucene is now requiring at least 1.2 (for ThreadLocal for instance,
> which is using BTW some WeakHashMap), maybe it is time to change ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
