[
https://issues.apache.org/jira/browse/LUCENE-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466341
]
Karl Wettin commented on LUCENE-550:
------------------------------------
New sunday, new code.
Hoss Man [15/Jan/07 12:16 AM]
> I've only briefly looked at the new stuff in contrib, because I got lost ...
> there isn't
> any package or class level javadocs or a build.xml in either contrib.
Tried to do something about the java docs. Also made a new fresh class diagram
with some comments in it. I can make it PDF or XUL if prefered.
That boxing error you fixed might be back. Where was it? Could not find it in
the patch (all adding and no -+ fix) and it was too late to apply your patch on
my local version..
> Hoss Man [15/Jan/07 12:16 AM]
>
> 1) some of these changes seem to be duplicated in LUCENE-774 and LUCENE-775
> ... just pointing that out for other people who might get confused.
Is it considered better practise to keep all my changes in this one huge issue?
I thought it could be nice to pop in minor patches such as them.
> 4) I would personally prefer..
> but that's a minor nit.
There has been a lot of refactoring of packages and class names as suggested.
(I'm still not happy with the notification listener classes.)
A few new changes to the core:
Lazy initialization of the fields collection in Document .
Some definalization to allow decoration of IndexReader.
http://www.nabble.com/IndexReader-can-not-be-decorated-tf3041647.html#a8461125
> Hoss Man [15/Jan/07 12:16 AM]
>
> 3) i don't think the Hits.setSearcher method you added is safe
It smeared out on java-dev:
http://www.nabble.com/Decorative-cache-%28and-Hits.setSearcher%29-tf3009848.html#a8428139
I did not investigate this any further with test code, but I have identitfied
lazy fields as a problem. Instead I'm considering a supplementary decorated
document cache on the IndexReader, and implementing a replacement for Hits.
Hoss Man [15/Jan/07 12:39 AM]
> I just realized that all of the tests in
> contrib/instantiated/src/test/java/org/apache/lucene/
> instantiated/assimilated/ are duplicates of tests from the core with a few
> line changes
> so they use an InstantiatedIndex to get a reader/writer/seracher etc.
This is not a bad idea at all, but I will not have time to do it right anytime
soon. It would be a simpler task if the facade was a part of the core, as this
is just the thing it was built for -- unison index handling. ;-)
Hoss Man [15/Jan/07 01:35 AM]
> Then i ran the tests, and got some errors -- which are included in
> test-reports.zip so you can check them out.
What tool do you recommend to inspect these reports?
I know for a fact that remote searchable will fail. I hope for someone to show
up, need it and fix it.
> InstantiatedIndex - faster but memory consuming index
> -----------------------------------------------------
>
> Key: LUCENE-550
> URL: https://issues.apache.org/jira/browse/LUCENE-550
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Store
> Affects Versions: 2.0.0
> Reporter: Karl Wettin
> Assigned To: Karl Wettin
> Attachments: issue550.jpg, test-reports.zip, trunk.diff,
> trunk.diff.bz2
>
>
> An non file centrinc all in memory index. Consumes some 2x the memory of a
> RAMDirectory (in a term satured index) but is between 3x-60x faster depending
> on application and how one counts. Average query is about 8x faster.
> IndexWriter and IndexModifier have been realized in InterfaceIndexWriter and
> InterfaceIndexModifier.
> InstantiatedIndex is wrapped in a new top layer index facade (class Index)
> that comes with factory methods for writers, readers and searchers for unison
> index handeling. There are decorators with notification handling that can be
> used for automatically syncronizing searchers on updates, et.c.
> Index also comes with FS/RAMDirectory implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
