[ 
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474033
 ] 

Mark Miller commented on LUCENE-794:
------------------------------------

Howdy Mark H, I have not got into making new SpanQuery tests yet, but at this 
point I could use some help/guidance. All of the original highlighter tests are 
passing with the new SpanScorer except for two: 

1. testFieldSpecificHighlighting

This will not pass the second assertion (ignore fields) because when i add the 
TokenStream to a MemoryIndex I have to add it to a field. I am stumped on 
getting around this one.

2. testOverlapAnalyzer2

Passes the first bunch but then fails on one. This is because I am looking up 
terms based on position since the Spans do not return the term text. The first 
assertion failing is looking for 'hi-<b>speed</b>' but finds '<b>hi-speed</b>' 
because both 'speed' and 'hi-speed' are at position 0...consequently both score 
a 1. Any thoughts? I was thinking about gathering all possible terms in the 
SpanQueryExtractor and someone using them...

Beyond that, I am sure you can find plenty of other things to point out . Have 
at me <g>

Any ideas on scoring would be appreciated as well.

Feel free to run with this on your own if you have time as well...or run with 
it a bit and pass it back, or just provide some guidance as I go...whatever 
works out best for you.

- Mark M

> Beginnings of a span based highlighter
> --------------------------------------
>
>                 Key: LUCENE-794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: CachedTokenStream.java, CachedTokenStream.java, 
> DefaultEncoder.java, Encoder.java, Formatter.java, Highlighter.java, 
> Highlighter.java, Highlighter.java, Highlighter.java, HighlighterTest.java, 
> HighlighterTest.java, HighlighterTest.java, HighlighterTest.java, 
> MemoryIndex.java, QuerySpansExtractor.java, QuerySpansExtractor.java, 
> QuerySpansExtractor.java, SimpleFormatter.java, SpanHighlighterTest.java, 
> SpanScorer.java
>
>
> This is some test code to start the work of adding a span based highlighting 
> approach to the existing highlighter in contrib. See 
> http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to