[
https://issues.apache.org/jira/browse/LUCENE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475987
]
Doron Cohen commented on LUCENE-818:
------------------------------------
I looked at Java IO as a reference for acceptable behavior in this regard.
If you close a file system object and try to use it,
- RandomAccessFile will throw IOException with: "No such file or directory"
- FileWriter will throw IOException with "Stream closed"
- FileOutputStream will throw IOException with "Stream closed"
So you could say that Java did not go all the way with a well defined
illegalState exception.
Databases on the other hand would give you a well definied error code.
I don't have a strong opinion if this is a must for Lucene or not.
But if this is to be added, one way to do it is to define a Closable interface
{ close(); isOpen() }, implement this interface in all public classes that need
to check open state (IndexWriter, IndexReader, etc.), add a single static
ensureOpen(Closable) method in a utils class that would throw the IllegalState
exception, and just call this method from every (public?) open-state open
dependent method. I think this would keep the 'noise' in the code to minimum.
> IndexWriter should detect when it's used after being closed
> -----------------------------------------------------------
>
> Key: LUCENE-818
> URL: https://issues.apache.org/jira/browse/LUCENE-818
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.1
> Reporter: Michael McCandless
> Assigned To: Michael McCandless
> Priority: Minor
>
> Spinoff from this thread on java-user:
> http://www.gossamer-threads.com/lists/lucene/java-user/45986
> If you call addDocument on IndexWriter after it's closed you'll hit a
> hard-to-explain NullPointerException (because the RAMDirectory was
> closed). Before 2.1, apparently you won't hit any exception and the
> IndexWrite will keep running but will have released it's write lock (I
> think).
> I plan to fix IndexWriter methods to throw an IllegalStateException if
> it has been closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
