[
https://issues.apache.org/jira/browse/LUCENE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479357
]
Yonik Seeley commented on LUCENE-818:
-------------------------------------
> we can use Hoss's neat approach and
> specifically catch the NPE and rethrow as an AlreadyClosedException?
I'm not enough of an expert to know if this would be faster or slower than a
simple fileMap==null check.
I would guess it depends on what needs to be set up in the stack frame to
potentially catch an exception, and if the try/catch/throw code prevents any
optimizations (such as inlining).
Also, catching a NPE seems a little icky to me... so w/o more info I'd lean
toward a fileMap==null check (if anything).
> IndexWriter should detect when it's used after being closed
> -----------------------------------------------------------
>
> Key: LUCENE-818
> URL: https://issues.apache.org/jira/browse/LUCENE-818
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Affects Versions: 2.1
> Reporter: Michael McCandless
> Assigned To: Michael McCandless
> Priority: Minor
> Attachments: LUCENE-818.patch, LUCENE-818.take2.patch,
> LUCENE-818.take3.patch, LUCENE-818.take4.patch
>
>
> Spinoff from this thread on java-user:
> http://www.gossamer-threads.com/lists/lucene/java-user/45986
> If you call addDocument on IndexWriter after it's closed you'll hit a
> hard-to-explain NullPointerException (because the RAMDirectory was
> closed). Before 2.1, apparently you won't hit any exception and the
> IndexWrite will keep running but will have released it's write lock (I
> think).
> I plan to fix IndexWriter methods to throw an IllegalStateException if
> it has been closed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
