[ 
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487981
 ] 

Sean O'Connor commented on LUCENE-794:
--------------------------------------

Thanks Mark. I had the trunk from a few days ago (perhaps a week), so that was 
just me being lazy : -).

Is there anything I should be aware of the: parser.setUseOldRangeQuery(true); 
in doSearching(String queryString)? [about  line 890 in 
SpanHighlighterTest.java]

I've read the javadocs which explain it a bit, but I don't think a understand 
enough to infer why you use it in the SpanHighterTest.java. If I can 
(relatively) safely ignore that, I will.

Sean


Mark Miller (JIRA) wrote:
    [ 
[1]https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487860
 ] 

Mark Miller commented on LUCENE-794:
------------------------------------

Sorry Sean, I forgot to mention that the patch is off of the latest 
Lucene trunk code.

The range query test should fail because they switched the query parser 
to return a constant score query instead of a range query. Cannot 
highlight a constant score query.

- Mark



  
SpanScorer and SimpleSpanFragmenter for Contrib Highlighter
-----------------------------------------------------------

                Key: LUCENE-794
                URL: [2]https://issues.apache.org/jira/browse/LUCENE-794
            Project: Lucene - Java
         Issue Type: Improvement
         Components: Other
           Reporter: Mark Miller
           Priority: Minor
        Attachments: CachedTokenStream.java, CachedTokenStream.java, 
CachedTokenStream.java, DefaultEncoder.java, Encoder.java, Formatter.java, 
Highlighter.java, Highlighter.java, Highlighter.java, Highlighter.java, 
Highlighter.java, HighlighterTest.java, HighlighterTest.java, 
HighlighterTest.java, HighlighterTest.java, MemoryIndex.java, 
QuerySpansExtractor.java, QuerySpansExtractor.java, QuerySpansExtractor.java, 
QuerySpansExtractor.java, SimpleFormatter.java, spanhighlighter.patch, 
spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch, 
spanhighlighter_patch_4.zip, SpanHighlighterTest.java, 
SpanHighlighterTest.java, SpanScorer.java, SpanScorer.java, 
WeightedSpanTerm.java


This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter package 
that scores just like QueryScorer, but scores a 0 for Terms that did not cause 
the Query hit. This gives 'actual' hit highlighting for the range of SpanQuerys 
and PhraseQuery. There is also a new Fragmenter that attempts to fragment 
without breaking up Spans.
See [3]http://issues.apache.org/jira/browse/LUCENE-403 for some background.
There is a dependency on MemoryIndex.
    

  

----------------------------------------------------------------------------------------
[1] 
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487860
[2] https://issues.apache.org/jira/browse/LUCENE-794
[3] http://issues.apache.org/jira/browse/LUCENE-403


> SpanScorer and SimpleSpanFragmenter for Contrib Highlighter
> -----------------------------------------------------------
>
>                 Key: LUCENE-794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: CachedTokenStream.java, CachedTokenStream.java, 
> CachedTokenStream.java, DefaultEncoder.java, Encoder.java, Formatter.java, 
> Highlighter.java, Highlighter.java, Highlighter.java, Highlighter.java, 
> Highlighter.java, HighlighterTest.java, HighlighterTest.java, 
> HighlighterTest.java, HighlighterTest.java, MemoryIndex.java, 
> QuerySpansExtractor.java, QuerySpansExtractor.java, QuerySpansExtractor.java, 
> QuerySpansExtractor.java, SimpleFormatter.java, spanhighlighter.patch, 
> spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch, 
> spanhighlighter_patch_4.zip, SpanHighlighterTest.java, 
> SpanHighlighterTest.java, SpanScorer.java, SpanScorer.java, 
> WeightedSpanTerm.java
>
>
> This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter 
> package that scores just like QueryScorer, but scores a 0 for Terms that did 
> not cause the Query hit. This gives 'actual' hit highlighting for the range 
> of SpanQuerys and PhraseQuery. There is also a new Fragmenter that attempts 
> to fragment without breaking up Spans.
> See http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to