[ 
https://issues.apache.org/jira/browse/LUCENE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510422
 ] 

Ning Li commented on LUCENE-938:
--------------------------------

Good catch, Steven!

One thing though: I thought we had assumed that there wouldn't be any buffered 
docs or delete terms when startTransaction(), so no local copies are necessary. 
That means no change to startTransaction() and rollbackTransaction(). If there 
could be buffered docs and delete terms when startTransaction(), then local 
copies should be made for buffered docs and localNumBufferedDeleteTerms should 
clone numBufferedDeleteTerms instead of just copying the reference.

> I/O exceptions can cause loss of buffered deletes
> -------------------------------------------------
>
>                 Key: LUCENE-938
>                 URL: https://issues.apache.org/jira/browse/LUCENE-938
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Steven Parkes
>            Assignee: Steven Parkes
>             Fix For: 2.3
>
>         Attachments: LUCENE-938.take2.patch, LUCENE-938.txt, LUCENE-938.txt
>
>
> Some I/O exceptions that result in segmentInfos rollback operations can cause 
> buffered deletes that existed before the rollback creation point to be 
> incorrectly lost when the IOException triggers a rollback.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to