[ 
https://issues.apache.org/jira/browse/LUCENE-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513390
 ] 

Michael McCandless commented on LUCENE-962:
-------------------------------------------

Good catch Steven!

I think where you put the try/finally is good.  The only tiny thing I
noticed is in your unit test when you create the MockRAMDirectory you
don't have to pass in an empty RAMDirectory; you can just use the
no-argument constructor instead.

I will commit this.

> I/O exception in DocsWriter add or updateDocument may not delete unreferenced 
> files
> -----------------------------------------------------------------------------------
>
>                 Key: LUCENE-962
>                 URL: https://issues.apache.org/jira/browse/LUCENE-962
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Steven Parkes
>            Assignee: Steven Parkes
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: LUCENE-962.patch.txt
>
>
> If an I/O exception is thrown in DocumentsWriter#addDocument or 
> #updateDocument, the stored fields files may not be cleaned up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to