[
https://issues.apache.org/jira/browse/LUCENE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516945
]
Michael McCandless commented on LUCENE-967:
-------------------------------------------
> Also, I think the addition of printing of elapsed time is redundant,
> because you get it anyhow as the elapsed time reported for the
> outermost task sequence. (?)
Duh, right :) I will remove that.
> 1) in ReadTokensTask change doLogic() to return the number of tokens
> processed in that specific call to doLogic() (differs from tokensCount
> which aggregates all calls).
Ahh good idea!
> 2) in TestPerfTaskLogic the comment in testReadTokens seems
> copy/pasted from testLineDocFile and should be changed.
Woops, will fix.
> - Also (I am not sure if it is worth your time, but) to really test it,
> you
> could open a reader against the created index and verify the number
> of docs, and also the index sum-of-DF comparing to the total tokens
> counts numbers in ReadTokensTask.
OK I added this too. Will submit new patch shortly.
> Add "tokenize documents only" task to contrib/benchmark
> -------------------------------------------------------
>
> Key: LUCENE-967
> URL: https://issues.apache.org/jira/browse/LUCENE-967
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Affects Versions: 2.3
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.3
>
> Attachments: LUCENE-967.patch, LUCENE-967.take2.patch
>
>
> I've been looking at performance improvements to tokenization by
> re-using Tokens, and to help benchmark my changes I've added a new
> task called ReadTokens that just steps through all fields in a
> document, gets a TokenStream, and reads all the tokens out of it.
> EG this alg just reads all Tokens for all docs in Reuters collection:
> doc.maker=org.apache.lucene.benchmark.byTask.feeds.ReutersDocMaker
> doc.maker.forever=false
> {ReadTokens > : *
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
