Awesome, thanks! I will commit shortly... Mike
"Peter Keegan" <[EMAIL PROTECTED]> wrote: > Hi Mike, > > I tested the patch and it looks good. > > Thanks, > Peter > > On 8/10/07, Peter Keegan <[EMAIL PROTECTED]> wrote: > > > > Heck, no need to apologize - no harm done. For all the great work by you > > and others, the least I can do is help find problems ;-) > > > > Peter > > > > On 8/10/07, Michael McCandless <[EMAIL PROTECTED]> wrote: > > > > > > > > > OK, sorry about this :( I will fix. > > > > > > Mike > > > > > > "Peter Keegan" <[EMAIL PROTECTED]> wrote: > > > > >it affects both 2.2 (released ) and trunk, right? > > > > > > > > I don't have a 2.2 index to test, but the code looks the same as the > > > > trunk. > > > > It would be tricky to write a unit test for this. I only noticed > > > because > > > > query performance went down the drain. > > > > > > > > Peter > > > > > > > > > > > > On 8/10/07, Michael McCandless <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > > > > Whoa, I see -- this was caused by my commit for LUCENE-888, and, it > > > > > affects both 2.2 (released ) and trunk, right? I think the fix is > > > to > > > > > add the corresponding constructor (openInput(String name, int > > > > > bufferSize)) into MMapDirectory but have it ignore the bufferSize? > > > > > > > > > > I will open a Jira issue. Thanks for catching this! > > > > > > > > > > Mike > > > > > > > > > > "Peter Keegan" <[EMAIL PROTECTED] > wrote: > > > > > > I have discovered a bug in 2.2 (trunk version) that prevents > > > > > > MMapDirectory > > > > > > from working. TermInfosReader has a new constructor that calls a > > > new > > > > > > version > > > > > > of FSDirectory.openInput(String, int). This new openInput > > > signature > > > > > isn't > > > > > > implemented in MMapDirectory, so FSDirectory is used instead. > > > > > > > > > > > > Should I submit this to JIRA? > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
