[
https://issues.apache.org/jira/browse/LUCENE-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542201
]
Michael McCandless commented on LUCENE-743:
-------------------------------------------
{quote}
Awesome! Thanks so much for pointing me there, Mike! I was getting a
little suicidal here already ...
{quote}
No problem, I lost some hairs tracking that one down too!!
OK, latest patch looks good! I love the new threaded unit test.
Only two smallish comments:
* You should also close fieldsReader when referencedSegmentReader !=
null, right? (in SegmentReader.doClose)
* In the new try/finally in reopenSegment: if you first setup
referencedSegmentReader, then can't that finally clause just be
clone.decRef() instead of duplicating code for decRef'ing norms,
closeNorms(), etc.?
> IndexReader.reopen()
> --------------------
>
> Key: LUCENE-743
> URL: https://issues.apache.org/jira/browse/LUCENE-743
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Otis Gospodnetic
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.3
>
> Attachments: IndexReaderUtils.java, lucene-743-take2.patch,
> lucene-743-take3.patch, lucene-743-take4.patch, lucene-743-take5.patch,
> lucene-743-take6.patch, lucene-743-take7.patch, lucene-743-take8.patch,
> lucene-743.patch, lucene-743.patch, lucene-743.patch, MyMultiReader.java,
> MySegmentReader.java, varient-no-isCloneSupported.BROKEN.patch
>
>
> This is Robert Engels' implementation of IndexReader.reopen() functionality,
> as a set of 3 new classes (this was easier for him to implement, but should
> probably be folded into the core, if this looks good).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
