[
https://issues.apache.org/jira/browse/LUCENE-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1059:
---------------------------------------
Attachment: LUCENE-1059.take2.patch
OK patch looks good to me! Thanks Tzvika!
One thing is QueryParser.java can't be changed (that code is
auto-written by JavaCC). Also I changed some of the single-character
append's from a size 1 string to a single character as suggested above
by Uwe Schindler. Attached new patch with these changes. I plan
to commit in a day or two.
> bad java practices which affect performance (result of code inspection)
> -----------------------------------------------------------------------
>
> Key: LUCENE-1059
> URL: https://issues.apache.org/jira/browse/LUCENE-1059
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Tzvika Barenholz
> Priority: Minor
> Attachments: inspections.diff, LUCENE-1059.take2.patch
>
>
> IntelliJ IDEA found the following issues in the Lucense source code and tests:
> 1) explicit for loops where calls to System.arraycopy() should have been
> 2) calls to Boolean constructor (in stead of the appropriate static
> method/field)
> 3) instantiation of unnecessary Integer instances for toString, instead of
> calling the static one
> 4) String concatenation using + inside a call to StringBuffer.append(), in
> stead of chaining the append calls
> all minor issues. patch is forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
