[ 
https://issues.apache.org/jira/browse/LUCENE-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyle Maxwell reopened LUCENE-1019:
----------------------------------

    Lucene Fields: [New, Patch Available]

Hi, after trying out the combined valuesource implementation suggested by 
Doron, I've found it to be _extremely_ cumbersome and brittle in practice.  
Therefore, I am reopening this ticket.  

- Trying to get explain information from the sub-ValueSources was quite 
difficult.
- There is much more code in my queries, leading to increased brittleness.
- The way in which caching is handled is now unclear.

Can this ticket please be reconsidered?  Thanks!

> CustomScoreQuery should support multiple ValueSourceQueries
> -----------------------------------------------------------
>
>                 Key: LUCENE-1019
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1019
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.2
>            Reporter: Kyle Maxwell
>         Attachments: CustomMultiQuery.v0.diff, CustomScoreQuery.v1.diff
>
>
> CustomScoreQuery's constructor currently accepts a subQuery, and a 
> ValueSourceQuery.  I would like it to accept multiple ValueSourceQueries.  
> The workaround of nested CustomScoreQueries works for simple cases, but it 
> quickly becomes either cumbersome to manage, or impossible to implement the 
> desired function.
> This patch implements CustomMultiScoreQuery with my desired functionality, 
> and refactors CustomScoreQuery to implement the special case of a 
> CustomMultiScoreQuery with 0 or 1 ValueSourceQueries.  This keeps the 
> CustomScoreQuery API intact.
> This patch includes basic tests, more or less taken from the original 
> implementation, and customized a bit to cover the new cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to