[ https://issues.apache.org/jira/browse/LUCENE-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550238 ]
Peter Keegan commented on LUCENE-1017: -------------------------------------- > What's the use case? Is there something that isn't possible with it as is? I would say "no", if we can conclude that there is no significant difference in performance between the 2 implementations. As a developer, when I see queries based on SpanQuery or PhraseQuery, this a tip that there is a potential performance impact. On the plus side, renaming the current implementation to 'BoostingSpanQuery' might give the developer a better hint of the methods of its superclass, too. Would you expect the cost of traversing the postings to be higher than reading the payload? Peter > BoostingTermQuery performance > ----------------------------- > > Key: LUCENE-1017 > URL: https://issues.apache.org/jira/browse/LUCENE-1017 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Affects Versions: 2.2 > Environment: all > Reporter: Peter Keegan > Priority: Minor > Attachments: BoostingTermQuery.java, BoostingTermQuery.patch, > termquery.patch > > > I have been experimenting with payloads and BoostingTermQuery, which I think > are excellent additions to Lucene core. Currently, BoostingTermQuery extends > SpanQuery. I would suggest changing this class to extend TermQuery and > refactor the current version to something like 'BoostingSpanQuery'. > The reason is rooted in performance. In my testing, I compared query > throughput using TermQuery against 2 versions of BoostingTermQuery - the > current one that extends SpanQuery and one that extends TermQuery (which I've > included, below). Here are the results (qps = queries per second): > TermQuery: 200 qps > BoostingTermQuery (extends SpanQuery): 97 qps > BoostingTermQuery (extends TermQuery): 130 qps > Here is a version of BoostingTermQuery that extends TermQuery. I had to > modify TermQuery and TermScorer to make them public. A code review would be > in order, and I would appreciate your comments on this suggestion. > Peter -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]