[ 
https://issues.apache.org/jira/browse/LUCENE-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554908
 ] 

Michael McCandless commented on LUCENE-1101:
--------------------------------------------

{quote}
But I think it would be cleaner/safer to move the responsibility to clear() 
from consumers to producers.
{quote}

+1

So, the contract of next(Token) is: if you are the source of Tokens, you must 
call Token.clear() before setting the fields in it & returning it.

> Tokenizers should reset positionIncrement to 1 in their next(Token result) 
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-1101
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1101
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>             Fix For: 2.3
>
>         Attachments: lucene-1101.patch, lucene-1101.patch
>
>
> Tokenizers which implement the reuse form of the next method:
>     next(Token result) 
> should reset the postionIncrement of the returned token to 1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to