[ https://issues.apache.org/jira/browse/LUCENE-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eks Dev updated LUCENE-1145: ---------------------------- Attachment: DSSQueueSizeOptimization.patch Simplification of the DisjunctionSumScorer. - removed cached field "private int queueSize" which mirrored ScorerDocQueue.size() and replaced it with method call. It is faster with this patch, but hardly measurable (test made with attached TestScorerPerformance) 585660ms vs 586090ms. Test on WIN XP Prof. Dual Core Intel T7300 2GHz with 6.0 java -server -Xbatch At a moment, I have no other configurations to test it, it would be good to see what happens on jvm 1.4 It makes sense to commit this as it simplifies (pff, ok, simpifies it a bit :) already complex code in DSScorer and is not slower. > DisjunctionSumScorer small tweak > -------------------------------- > > Key: LUCENE-1145 > URL: https://issues.apache.org/jira/browse/LUCENE-1145 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Environment: all > Reporter: Eks Dev > Priority: Trivial > Attachments: DisjunctionSumScorerOptimization.patch, > DSSQueueSizeOptimization.patch, TestScorerPerformance.java > > > Move ScorerDocQueue initialization from next() and skipTo() methods to the > Constructor. Makes DisjunctionSumScorer a bit faster (less than 1% on my > tests). > Downside (if this is one, I cannot judge) would be throwing IOException from > DisjunctionSumScorer constructors as we touch HardDisk there. I see no > problem as this IOException does not propagate too far (the only modification > I made is in BooleanScorer2) > if (scorerDocQueue == null) { > initScorerDocQueue(); > } > > Attached test is just quick & dirty rip of TestScorerPerf from standard > Lucene test package. Not included as patch as I do not like it. > All test pass, patch made on trunk revision 613923 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]