[ 
https://issues.apache.org/jira/browse/LUCENE-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578897#action_12578897
 ] 

Michael McCandless commented on LUCENE-1232:
--------------------------------------------

I like your new patch Doron.

But we still have the "backwards compatibility when someone saves the index 
version across an upgrade to 2.4" problem.  In theory someone could call 
getVersion(), store this into a database (say), upgrade, restart their app, 
pull the old version from the database, and compare it to the new getVersion() 
result.

Though, I think this would happen extremely rarely in practice?  I would expect 
the version is almost always only saved within the JVM, and not persisted, and 
is used to decide when to reopen a reader.  And since you'd have to shut down 
all readers & your writer in order to do an upgrade to 2.4, you will have 
re-opened the readers already.

> Use segments generation instead of version
> ------------------------------------------
>
>                 Key: LUCENE-1232
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1232
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.1, 2.2, 2.3, 2.3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: check.version.vs.gen.diff, LUCENE-1232.dc.patch, 
> LUCENE-1232.patch
>
>
> Right now the segments file stores generation, a long starting with 0
> that increments by 1 with each commit, and version, a long starting
> with System.currentTimeMillis() that also increments by 1 with each
> commit.
> I think they are redundant so we can replace all methods/uses of
> version with generation instead.
> Spinoff from LUCENE-1228.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to