[
https://issues.apache.org/jira/browse/LUCENE-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596636#action_12596636
]
Otis Gospodnetic commented on LUCENE-1216:
------------------------------------------
Thanks for the updates and sorry for the 2 months wait. I had another look at
this. Why does whitespace character still get special treatment - that is, why
is there this method:
/**
* Sets white space char as deimiter
*
* By default, whitespaces are not delimters.
* @param flag True to switch whitespace as delimiter
*/
public void setWhitespaceDelimiter(boolean flag){
this.whitespaceDelimiter=flag;
}
If one wants to use space as a delimiter, wouldn't one just call addDelimiter('
') instead of using setWhitespaceDelimiter(true)?
Your unit test is nice and clean, but have a look at the javadoc fo JUnit,
especially startUp() and tearDown() methods. Tour test* methods have several
lines of code that repeats in each test* method. You could easily move some of
that to startUp() (called before each test) and tearDown().
Would you like to make this change before I commit?
Thanks!
> CharDelimiterTokenizer
> ----------------------
>
> Key: LUCENE-1216
> URL: https://issues.apache.org/jira/browse/LUCENE-1216
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Hiroaki Kawai
> Attachments: CharDelimiterTokenizer.java,
> CharDelimiterTokenizer.java, TestCharDelimiterTokenizer.java
>
>
> WhitespaceTokenizer is very useful for space separated languages, but my
> Japanese text is not always separated by a space. So, I created an
> alternative Tokenizer that we can specify the delimiter. The file submitted
> will be an improvement of the current WhitespaceTokenizer.
> I tried to extend it from CharTokenizer, but CharTokenizer has a limitation
> that a token can't be longer than 255 chars.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
