[
https://issues.apache.org/jira/browse/LUCENE-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607117#action_12607117
]
Karl Wettin commented on LUCENE-1312:
-------------------------------------
Hi Jason!
bq. Fixed this bug and one related to termenum with no term. These made
SegmentMerger fail.
Can you please supply a test case that demonstrate SegmentMerger failing? Your
next() in InstantiatedTermEnum() changes the behaviour
InstantiatedIndexReader#terms() compared to IndexReader#terms() and makes the
index comparation test to to fail:
{code}
junit.framework.AssertionFailedError: expected:<a:0> but was:<a:1>
at
org.apache.lucene.store.instantiated.TestIndicesEquals.testEquals(TestIndicesEquals.java:244)
{code}
InstantiatedIndex#fieldSettingsByFieldName that getFieldNames(FieldOption) seem
to only be updated by InstantiatedIndexWriter and not when populated by
InstantiatedIndex(IndexReader).
Can you please supply test cases that demonstrate getFieldNames(FieldOption)
works with both index population strategies?
I think you can factor out the FieldSetting class from InstantiatedIndexWriter
as it now is used by InstantiatedIndex and InstantiatedIndexReader too.
bq. A few additional updates related to deleted docs in InstantiatedIndexReader
This looks good. I noticed that TestIndicesEquals does not actually delete any
documents and make sure the indices still equals. I can fix that.
Also, please try not to reformat the code, it makes it harder to see the
important changes.
Thanks!
> InstantiatedIndexReader does not implement getFieldNames properly
> -----------------------------------------------------------------
>
> Key: LUCENE-1312
> URL: https://issues.apache.org/jira/browse/LUCENE-1312
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/*
> Reporter: Jason Rutherglen
> Assignee: Karl Wettin
> Attachments: lucene-1312.patch, lucene-1312.patch
>
>
> Causes error in org.apache.lucene.index.SegmentMerger.mergeFields
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
