[
https://issues.apache.org/jira/browse/LUCENE-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610244#action_12610244
]
Jason Rutherglen commented on LUCENE-1314:
------------------------------------------
> check isCurrent()
I thought we wanted to check a commit on a clone that the index is current?
Does it need to be in a clone only portion of the code? Which class is best?
> clone() the norms
We need to clone norms. I want to make cloning deletedDocs and norms optional
mainly because it is a waste in Ocean to clone norms. Is the best way to give
the option parameters to the clone method (breaking Cloneable)? An additional
option could be readOnly. Perhaps norms or deletedDocs becomes readOnly if
they are ref copied and not cloned. IndexReader.open and reopen would need a
readOnly parameter. Or should a subclass of SegmentReader handle cloning or
refing norms and deletedDocs.
I think it may be easiest to have readOnly be a part of this patch. I wanted
to separate out the FieldsReader synchronization code into a separate patch but
then this patch would have been messed up without it (the new FieldsReader per
SegmentReader issue). Readonly may end up being similar.
The newlines is another Eclipse thing I haven't figured out yet.
> IndexReader.reopen(boolean force)
> ---------------------------------
>
> Key: LUCENE-1314
> URL: https://issues.apache.org/jira/browse/LUCENE-1314
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Index
> Affects Versions: 2.3.1
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Minor
> Attachments: lucene-1314.patch, lucene-1314.patch, lucene-1314.patch,
> lucene-1314.patch, lucene-1314.patch, lucene-1314.patch
>
>
> Based on discussion
> http://www.nabble.com/IndexReader.reopen-issue-td18070256.html. The problem
> is reopen returns the same reader if there are no changes, so if docs are
> deleted from the new reader, they are also reflected in the previous reader
> which is not always desired behavior.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
