[ 
https://issues.apache.org/jira/browse/LUCENE-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611516#action_12611516
 ] 

Michael McCandless commented on LUCENE-1329:
--------------------------------------------

Jason, have you run any scale tests (w/ many threads) to confirm whether 
volatile is faster than using synchronized, for this case?  I'm especially 
curious on what happens with JRE 1.4, since with this patch it is now 
synchronized and volatile.

I think we should, at least in addition but perhaps instead, create a way to 
open a read-only IndexReader.  This way no synchronization nor volatile would 
be necessary when accessing deletedDocs.

> Remove synchronization in SegmentReader.isDeleted
> -------------------------------------------------
>
>                 Key: LUCENE-1329
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1329
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3.1
>            Reporter: Jason Rutherglen
>            Priority: Trivial
>         Attachments: lucene-1329.patch
>
>
> Removes SegmentReader.isDeleted synchronization by using a volatile 
> deletedDocs variable on Java 1.5 platforms.  On Java 1.4 platforms 
> synchronization is limited to obtaining the deletedDocs reference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to