[
https://issues.apache.org/jira/browse/LUCENE-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eks Dev updated LUCENE-1219:
----------------------------
Attachment: LUCENE-1219.extended.patch
Mike,
This new patch includes take3 and adds the following:
Fieldable Document.getStoredBinaryField(String name, byte[] scratch);
where scratch param represents user byte buffer that will be used in case it is
big enough, if not, it will be simply allocated like today. If scratch is used,
you get the same object through Fieldable.getByteValue()
for this to work, I added one new method in Fieldable
abstract Fieldable getBinaryField(byte[] scratch);
the only interesting implementation is in LazyField
The reason for this is in my previous comment
this does not affect issues from take3 at all, but is dependant on it, as you
need to know the length of byte[] you read. take3 remains good to commit, I
just did not know how to make one isolated patch with only these changes
without too much work in text editor
> support array/offset/ length setters for Field with binary data
> ---------------------------------------------------------------
>
> Key: LUCENE-1219
> URL: https://issues.apache.org/jira/browse/LUCENE-1219
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Eks Dev
> Assignee: Michael McCandless
> Priority: Minor
> Attachments: LUCENE-1219.extended.patch, LUCENE-1219.patch,
> LUCENE-1219.patch, LUCENE-1219.patch, LUCENE-1219.patch,
> LUCENE-1219.take2.patch, LUCENE-1219.take3.patch
>
>
> currently Field/Fieldable interface supports only compact, zero based byte
> arrays. This forces end users to create and copy content of new objects
> before passing them to Lucene as such fields are often of variable size.
> Depending on use case, this can bring far from negligible performance
> improvement.
> this approach extends Fieldable interface with 3 new methods
> getOffset(); gettLenght(); and getBinaryValue() (this only returns reference
> to the array)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
