[
https://issues.apache.org/jira/browse/LUCENE-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1356:
-------------------------------
Attachment: 1356-2.patch
Marked the constructor as deprecated, created another one (protected) which
accepts PQ only and modified TopFieldDocCollector to use the new c'tor instead
of the deprecated one.
Also added javadoc.
> Allow easy extensions of TopDocCollector
> ----------------------------------------
>
> Key: LUCENE-1356
> URL: https://issues.apache.org/jira/browse/LUCENE-1356
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 2.3.3
>
> Attachments: 1356-2.patch, 1356.patch
>
>
> TopDocCollector's members and constructor are declared either private or
> package visible. It makes it hard to extend it as if you want to extend it
> you can reuse its *hq* and *totatlHits* members, but need to define your own.
> It also forces you to override getTotalHits() and topDocs().
> By changing its members and constructor (the one that accepts a PQ) to
> protected, we allow users to extend it in order to get a different view of
> 'top docs' (like TopFieldCollector does), but still enjoy its getTotalHits()
> and topDocs() method implementations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
