[ 
https://issues.apache.org/jira/browse/LUCENE-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Lalevée updated LUCENE-1344:
------------------------------------

    Attachment: MANIFEST.MF.diff
                LUCENE-1344-r690691.patch

You are right to ask Michael, one part of the patch was risky, the part that 
was computing the version dynamically. I changed the way the properties were 
loaded and it made some mess with building the contrib during the release 
process.
So I removed it. So then instead of 
{noformat}
ant -Dversion=2.3.0-rc1 -Dspec.version=2.3.0 clean dist dist-src 
generate-maven-artifacts
{noformat}
there should be
{noformat}
ant -Dversion=2.3.0-rc1 -Dspec.version=2.3.0 -Dbundle.version=2.3.0.cr1 clean 
dist dist-src generate-maven-artifacts
{noformat}

Note that there is no spell mistake here. The OSGi specification expects that 
the qualifier part of the version (the last one) is incremented based on the 
lexical order. So 2.3.0 < 2.3.0.rc1. But 2.3.0.alpha1 < 2.3.0.beta1 < 
2.3.0.beta2 < 2.3.0.cr1 < 2.3.0.final

About the remaining patch, it is really just about adding additional fields 
into the manifest.mf, addition which is triggered by the existence of the 
bundle.manifest.file property. I attached the diff of the manifest of the core 
of a 2.4.0 release, between the trunk version and the patched one. And If I 
remove the property bundle.manifest.file from the build.xml, there is no diff 
at all (apart from the Implementation-Version because of the timestamp).



> Make the Lucene jar an OSGi bundle
> ----------------------------------
>
>                 Key: LUCENE-1344
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1344
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Nicolas Lalevée
>             Fix For: 2.4
>
>         Attachments: LUCENE-1344-r679133.patch, LUCENE-1344-r690675.patch, 
> LUCENE-1344-r690691.patch, MANIFEST.MF.diff
>
>
> In order to use Lucene in an OSGi environment, some additional headers are 
> needed in the manifest of the jar. As Lucene has no dependency, it is pretty 
> straight forward and it ill be easy to maintain I think.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to