[
https://issues.apache.org/jira/browse/LUCENE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628568#action_12628568
]
Mark Lassau commented on LUCENE-1151:
-------------------------------------
Michael,
Great work. I am glad we are moving to have the bug fixed by default, rather
than the other way around.
Please indulge me a couple of small nitpicks before I get to my main point in
another comment
* Your comment above the static initializer is not correct:
{noformat}
// Default to false (fixed the bug), unless the system prop is set
{noformat}
should read:
{noformat}
// Default to true (fixed the bug), unless the system prop is set
{noformat}
* The re-use of the variable a in TestStandardAnalyzer.testDomainNames() does
not really guarantee that you are testing the default behaviour of
StandardAnalyzer.
I would recommend resetting a in setUp(), or explicitly constructing it in test
method.
Given that the code is "temporary" until v3.0, feel free to ignore me ;)
> Fix StandardAnalyzer to not mis-identify HOST as ACRONYM by default
> -------------------------------------------------------------------
>
> Key: LUCENE-1151
> URL: https://issues.apache.org/jira/browse/LUCENE-1151
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.4
>
> Attachments: LUCENE-1151.patch
>
>
> Coming out of the discussion around back compatibility, it seems best to
> default StandardAnalyzer to properly fix LUCENE-1068, while preserving the
> ability to get the back-compatible behavior in the rare event that it's
> desired.
> This just means changing the replaceInvalidAcronym = false with = true, and,
> adding a clear entry to CHANGES.txt that this very slight non back compatible
> change took place.
> Spinoff from here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/57517#57517
> I'll commit that change in a day or two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
