[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657243#action_12657243
]
Michael McCandless commented on LUCENE-1483:
--------------------------------------------
But, with this new approach (single pqueue that "knows" when we transition to
the next segment) aren't we back to HitCollector not only knowing the doc base
but also the IndexReader we are now advancing to? (We should remove the
setDocBase call).
Or I guess we could pre-add the doc (in Scorer) so that collect is called with
the full docID.
Still that "tiny" performance cost nags at me ;) Most of the time the add
would not have been necessary since the number of inserts into the pqueue
should be a small percentage for a large number of hits. And this is the
hotspot of searching for Lucene, so maybe we should not add on this cost even
if it's tiny? And we can always wrap a collector that doesn't implement
setIndexReader and pre-add the docId for it. It's like an "expert"
DocCollector API vs the normal one.
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
