[ https://issues.apache.org/jira/browse/LUCENE-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659445#action_12659445 ]
Uwe Schindler commented on LUCENE-1496: --------------------------------------- I am thinking about extending TrieUtils and TrieRangeQuery for 32bit values (ints and floats). Doing this, the other methods in NumberUtils would be obsolete, too. This was just a suggestion, maybe we should talk a little bit more about this. On my first look through the code, I had not seen, that NumberUtils also supports doubles like TrieUtils, the only difference is the use of doubleToLongBits() vs. doubleToRawLongBits(). I am not sure what is better :-(, does anybody know more about this? Im my opinion the version with/without raw also normalizes doubles, so NaN compares with ==, anything other? To my changes in TrieUtils for support of 32bit: I am currently not sure how to do this elegant. Esp. the auto detection of trie encoding is not so happy on changing this :-( As 2.9 is not yet released, I have time to change the classes and signatures without worry about deprecation and format changes. So a good point to unify TrieUtils and NumberUtils. Maybe TrieRangeQuery will make it into the core, when flexible indexing is available. So my questions: Is anybody interested in TrieUtils also support 32bit? Why not unify NumberUtils and TrieUtils? Any ideas? > Move solr NumberUtils to lucene > ------------------------------- > > Key: LUCENE-1496 > URL: https://issues.apache.org/jira/browse/LUCENE-1496 > Project: Lucene - Java > Issue Type: Task > Reporter: Ryan McKinley > Priority: Trivial > Fix For: 2.9 > > > solr includes a NumberUtils class with some general utilities for dealing > with tokens and numbers. > This should be in lucene rather then solr. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org