[
https://issues.apache.org/jira/browse/LUCENE-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan McKinley updated LUCENE-1503:
----------------------------------
Attachment: LUCENE-1503-spatial-filter-builder.patch
this patch renames:
CartesianPolyFilter => CartesianPolyFilterBuilder
DistanceQuery => DistanceQueryBuilder
now everything that ends in "Filter" is a lucene Filter and everything that
ends in "Query" is a lucene Query.
> refactor spatial contrib "Filter" "Query" classes
> -------------------------------------------------
>
> Key: LUCENE-1503
> URL: https://issues.apache.org/jira/browse/LUCENE-1503
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Attachments: LUCENE-1503-spatial-filter-builder.patch
>
>
> From erik's comments in LUCENE-1387
> * Maybe the Filter's should be using the DocIdSet API rather than the
> BitSet deprecated stuff? We can refactor that after being committed I
> supposed, but not something we want to leave like that.
> * DistanceQuery is awkwardly named. It's not an (extends) Query.... it's
> a POJO with helpers. Maybe DistanceQueryFactory? (but it creates a Filter
> also)
> * CartesianPolyFilter is not a Filter (but CartesianShapeFilter is)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
