[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660465#action_12660465
]
Michael McCandless commented on LUCENE-1483:
--------------------------------------------
Patch looks great! I will run some perf tests once I'm back at home
base (still on vacation now, far away from home!). Some comments:
* The comment "use multiple queues" in IndexSearcher.java isn't
right -- it should be "use single reader"?
* I think FieldValueHitQueue.getComparatorPolicy should receive
subreaders? EG when there's only one sub-reader, straight ORD is
best. And possibly its order in the sort? We may want to move
getComparatorPolicy into SortField so that one may override for
"expert" cases? But we could do this later.
* We should fix sorting of sub-readers by maxDoc() to be done once,
not per query?
* I think we should sort sub-readers by numDocs() not maxDoc()?
* We should fix javadocs of MultiReaderHitCollector to explain that
sub-readers are visited not-in-order. (And other javadoc fixes,
but this can wait for the "polishing" phase...).
* I like the "don't fill fields" option
> Change IndexSearcher multisegment searches to search each individual segment
> using a single HitCollector
> --------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, sortBench.py, sortCollate.py
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
