[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661304#action_12661304
]
Michael McCandless commented on LUCENE-1483:
--------------------------------------------
{quote}
> I'm trying to get local lucene and solr to play nice (SOLR-773). The hoops
> you have to jump through to avoid memory leaks make the final code too
> strange and not reusable.
{quote}
With this patch we are changing how custom sorting works.
Previously, Lucene would iterate the terms for you, asking you to
produce a Comparable for each one. With this patch, we are asking you
to implement FieldComparator, which compares docs/slots directly and
must be aware of switching sub-readers during searching.
Ryan, can you have a look at FieldComparator to see if it "works" for
local lucene (and any other feedback on it)?
I think the best outcome here would be to get this issue done, and
then get local lucene switched over to this new API (so local lucene
sees the benefits of the new API, and sidesteps the memory leak in
LUCENE-1304).
We may still need to do LUCENE-1304 in case others hit the memory leak
of the old custom sort API.
> Change IndexSearcher multisegment searches to search each individual segment
> using a single HitCollector
> --------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483-partial.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, sortBench.py, sortCollate.py
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
