[ 
https://issues.apache.org/jira/browse/LUCENE-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664566#action_12664566
 ] 

Jason Rutherglen commented on LUCENE-1476:
------------------------------------------

{quote}
it's fine to expose this API, mark it expert & subject to
change, and state that it simply returns the current deleted docs
BitVector and any synchronization issues must be handled by the app.
Probably it should be package private or protected. 
{quote}

+1 Sounds good

{quote}
Also, I think Multi*Reader would not implement this API? Meaning
you must get the individual SegmentReader and ask it.
{quote}

Why?  The returned iterator can traverse the multiple bitvectors.

{quote}
I think one weak part of
the design is the blocking copy-on-write required for the first
deletion on a newly cloned reader. The time taken is in proportion to
the size of the segment. 
{quote}

If the segment is large, tombstones can solve this.

> BitVector implement DocIdSet
> ----------------------------
>
>                 Key: LUCENE-1476
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1476
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Jason Rutherglen
>            Priority: Trivial
>         Attachments: LUCENE-1476.patch, quasi_iterator_deletions.diff
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> BitVector can implement DocIdSet.  This is for making 
> SegmentReader.deletedDocs pluggable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to