[ 
https://issues.apache.org/jira/browse/LUCENE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670341#action_12670341
 ] 

Mark Harwood commented on LUCENE-1531:
--------------------------------------

Looks good to me. The only thing I would be tempted to add is a very brief 
description of the BoostingTermQuery in the DTD (i.e. explaining it's 
dependency on payloads as a differentiator). 
I know this duplicates some of the Javadocs but I have developers who refer to 
the generated XML syntax docs solely as an abstraction away from the underlying 
Java classes and on first-read it is not obvious that this tag requires at the 
least special index support.

I will re-generate the HTML docs using DTDDoc later once I've added support for 
the new Trie-based queries/filters (Uwe, if you're reading this let me know if 
you think the Trie API has stabilised).



> contrib/xml-query-parser, BoostingTermQuery support
> ---------------------------------------------------
>
>                 Key: LUCENE-1531
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1531
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.4
>            Reporter: Karl Wettin
>            Assignee: Karl Wettin
>             Fix For: 2.9
>
>         Attachments: LUCENE-1531.txt, LUCENE-1531.txt
>
>
> I'm not 100% on this patch. 
> BooleanTermQuery is a part of the spans family, but I generally use that 
> class as a replacement for TermQuery.  Thus in the DTD I have stated that it 
> can be a part of the root queries as well as a part of a span. 
> However, SpanFooQueries xml elements are named <SpanFoo/> rather than 
> <SpanFooQuery/>, I have however chosen to call it <BoostingTermQuery/>. It 
> would be possible to set it up so it would be parsed as <SpanBoostingTerm/> 
> when inside of a <SpanSomething>, but I just find that confusing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to