[ 
https://issues.apache.org/jira/browse/LUCENE-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677507#action_12677507
 ] 

Mark Harwood commented on LUCENE-1500:
--------------------------------------

OK - choices are:

1) Throw a RuntimeException with a more useful diagnostic message
2) Throw a new checked Exception (introducing possible compile errors in 
existing client code)
3) Check for the error condition and ignore (as done in the current patch)

This feels to me like one of those "there's something seriously wrong with the 
codebase" problems rather than an invalid bit of data or user input which is 
external to the system so my personal preference is to lean towards 1). 



> Highlighter throws StringIndexOutOfBoundsException
> --------------------------------------------------
>
>                 Key: LUCENE-1500
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1500
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>    Affects Versions: 2.4
>         Environment: Found this running the example code in Solr (latest 
> version).
>            Reporter: David Bowen
>            Assignee: Michael McCandless
>             Fix For: 2.4.1, 2.9
>
>         Attachments: LUCENE-1500.patch, patch.txt
>
>
> Using the canonical Solr example (ant run-example) I added this document 
> (using exampledocs/post.sh):
> <add><doc>
>   <field name="id">Test for Highlighting 
> StringIndexOutOfBoundsExcdption</field>
>   <field name="name">Some Name</field>
>   <field name="manu">Acme, Inc.</field>
>   <field name="features">Description of the features, mentioning various 
> things</field>
>   <field name="features">Features also is multivalued</field>
>   <field name="popularity">6</field>
>   <field name="inStock">true</field>
> </doc></add>
> and then the URL 
> http://localhost:8983/solr/select/?q=features&hl=true&hl.fl=features caused 
> the exception.
> I have a patch.  I don't know if it is completely correct, but it avoids this 
> exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to