[ 
https://issues.apache.org/jira/browse/LUCENE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-652:
--------------------------------------

    Attachment: LUCENE-652.patch

I added o.a.l.document.CompressionTools, with static methods to
compress & decompress, and deprecated Field.Store.COMPRESS.

I also found two separate bugs:

  * With Field.Store.COMPRESS we were running compression twice
    (unnecessarily); I've fixed that.

  * If you try to make a Field(byte[], int offset, int length,
    Store.COMPRESS), you'll hit an AIOOBE.  I think we don't need to
    fix this one since it's in now-deprecated code, and with 2.9,
    users can migrate to CompressionTools.

I plan to commit in a day or two.


> Compressed fields should be "externalized" (from Fields into Document)
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-652
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 1.9, 2.0.0, 2.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-652.patch
>
>
> Right now, as of 2.0 release, Lucene supports compressed stored fields.  
> However, after discussion on java-dev, the suggestion arose, from Robert 
> Engels, that it would be better if this logic were moved into the Document 
> level.  This way the indexing level just stores opaque binary fields, and 
> then Document handles compress/uncompressing as needed.
> This approach would have prevented issues like LUCENE-629 because merging of 
> segments would never need to decompress.
> See this thread for the recent discussion:
>     http://www.gossamer-threads.com/lists/lucene/java-dev/38836
> When we do this we should also work on related issue LUCENE-648.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to