[
https://issues.apache.org/jira/browse/LUCENE-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695462#action_12695462
]
Michael McCandless commented on LUCENE-1539:
--------------------------------------------
This patch looks good -- some questions:
* Is CreateWikiIndex intended to be committed? I thought not? Ie I
though the goal w/ this issue is add the necessary tasks so that
CreateWikiIndex would be done as an alg.
* I think we shouldn't bump to Java 1.5 -- it's only CreateWikiIndex
that needs it anyway (in only 2 places).
* PrintReaderTask never closes the reader.
* Not sure why you needed to relax private -> protected in AddDocTask?
> Improve Benchmark
> -----------------
>
> Key: LUCENE-1539
> URL: https://issues.apache.org/jira/browse/LUCENE-1539
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1539.patch, LUCENE-1539.patch, sortBench2.py,
> sortCollate2.py
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Benchmark can be improved by incorporating recent suggestions posted
> on java-dev. M. McCandless' Python scripts that execute multiple
> rounds of tests can either be incorporated into the codebase or
> converted to Java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
