[ 
https://issues.apache.org/jira/browse/LUCENE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697718#action_12697718
 ] 

Mark Miller commented on LUCENE-1588:
-------------------------------------

hmm - looks like we didnt make FieldComparatorSource serializable like 
SortComparatorSource -- so no need for the serialVersionUID.

Couple other picky comments:

return void at end of the constructor could go.

might remove the nextReader comment or change it ie this space intentionally 
left blank.

> Update Spatial Lucene sort to use FieldComparatorSource
> -------------------------------------------------------
>
>                 Key: LUCENE-1588
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1588
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: patrick o'leary
>            Assignee: patrick o'leary
>            Priority: Trivial
>             Fix For: 2.9
>
>         Attachments: LUCENE-1588.patch
>
>
> Update distance sorting to use FieldComparator sorting as opposed to 
> SortComparator

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to