Ah, right - thats basically what I was suggesting, though I was thinking
that we might need to resolve twice, but of course your right and we
don't have to. Lucene does still use fshq for back compat (for custom
field source I think?), but I can just do the auto resolution in
IndexSearcher only in non legacy mode and restore auto resolution to
fshq. That will avoid the harmless but wasteful double resolve in legacy
mode. Had no code to look at when I sent that out.
- Mark
Michael McCandless wrote:
Urgh, right. Can't we simply restore the AUTO resolution into it?
Existing (direct) usage of it must be passing in the top-level
IndexReader. (Lucene doesn't use FSHQ internally).
Mike
On Thu, Apr 23, 2009 at 6:48 PM, Mark Miller <markrmil...@gmail.com> wrote:
Just got off the train and ny to ct has a brilliant bar car, so lest I
forget:
1483 moved auto resolution from fshq to indexsearcher - which is a back
compat break if you were using a fshq without indexsearcher (Solr does it -
anyone could). Annoying. If I remember right, I did it to resolve auto on
the multireader rather than each individual segment reader. So the change is
needed and not allowed. Perhaps it could just re-resolve like before though
- if indexsearcher has already resolved, fine, otherwise it will be done
again at the fshq level. Ill issue it up later.
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
