[
https://issues.apache.org/jira/browse/LUCENE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702720#action_12702720
]
Michael McCandless commented on LUCENE-1593:
--------------------------------------------
{quote}
So if we work against the branch and when you execute "ant test-tag" we somehow
detect you don't have the latest revision and download it, it'll work ok? Maybe
add a checksum file, or a revision file to the branch and have the test
download it and compare? Or, when the test extracts the branch, it will create
a file with the revision information, and when you'll run the test it will
compare the branch's revision to your file?
I'm sure there's some way to solve it, but unfortunately I'm not overly
familiar with Ant's capabilities, so I appologize if I'm not proposing anything
too intelligent .
{quote}
Well, if we did branch only (no tag), we can't auto-update your checkout of the
branch, unless we also auto-update your main checkout (sometimes we change
internal APIs). I don't think we should auto update your main checkout when
you run "ant test-tag".
Why not just keep using the current tag approach? It works correctly... and
it's not so bad to retag whenever we have to change back compat tests.
> Optimizations to TopScoreDocCollector and TopFieldCollector
> -----------------------------------------------------------
>
> Key: LUCENE-1593
> URL: https://issues.apache.org/jira/browse/LUCENE-1593
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Shai Erera
> Fix For: 2.9
>
>
> This is a spin-off of LUCENE-1575 and proposes to optimize TSDC and TFC code
> to remove unnecessary checks. The plan is:
> # Ensure that IndexSearcher returns segements in increasing doc Id order,
> instead of numDocs().
> # Change TSDC and TFC's code to not use the doc id as a tie breaker. New docs
> will always have larger ids and therefore cannot compete.
> # Pre-populate HitQueue with sentinel values in TSDC (score = Float.NEG_INF)
> and remove the check if reusableSD == null.
> # Also move to use "changing top" and then call adjustTop(), in case we
> update the queue.
> # some methods in Sort explicitly add SortField.FIELD_DOC as a "tie breaker"
> for the last SortField. But, doing so should not be necessary (since we
> already break ties by docID), and is in fact less efficient (once the above
> optimization is in).
> # Investigate PQ - can we deprecate insert() and have only
> insertWithOverflow()? Add a addDummyObjects method which will populate the
> queue without "arranging" it, just store the objects in the array (this can
> be used to pre-populate sentinel values)?
> I will post a patch as well as some perf measurements as soon as I have them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
