Ok, I'll create another patch a bit later today
----- Original Message ---- > From: Michael McCandless (JIRA) <[email protected]> > To: [email protected] > Sent: Monday, 27 April, 2009 16:34:30 > Subject: [jira] Commented: (LUCENE-1616) add one setter for start and end > offset to OffsetAttribute > > > [ > https://issues.apache.org/jira/browse/LUCENE-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703144#action_12703144 > > ] > > Michael McCandless commented on LUCENE-1616: > -------------------------------------------- > > bq. removing separate looks a bit better for me as it forces users to think > "attomic" about offset <=> {start, end}. > > This is my thinking as well. > > And in general I prefer one clear way to do something (the Python way) > instead > providing various different ways to do the same thing (the Perl way). > > > add one setter for start and end offset to OffsetAttribute > > ---------------------------------------------------------- > > > > Key: LUCENE-1616 > > URL: https://issues.apache.org/jira/browse/LUCENE-1616 > > Project: Lucene - Java > > Issue Type: Improvement > > Components: Analysis > > Reporter: Eks Dev > > Priority: Trivial > > Fix For: 2.9 > > > > Attachments: LUCENE-1616.patch > > > > > > add OffsetAttribute. setOffset(startOffset, endOffset); > > trivial change, no JUnit needed > > Changed CharTokenizer to use it > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
