[ 
https://issues.apache.org/jira/browse/LUCENE-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704049#action_12704049
 ] 

Michael McCandless commented on LUCENE-1618:
--------------------------------------------

Patch looks good Jason!

Can you add copyright header & CHANGES.txt entry, and remove some noise (eg 
TestIndexWriterReader.java)?

Also: I think you should allow any Directory instance as primary/secondary?  
(You're hardwiring to RAMDir/FSDir now).  I realize NRT's use of this will be a 
RAMDir/FSDir, but I think this dir can be generic.  Can you also implement 
listAll()?

Finally: maybe for the "tee" (IndexOutput "writes through" two Dirs, suggested 
above) functionality, we should create a different Directory impl?

> Allow setting the IndexWriter docstore to be a different directory
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1618
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1618
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.4.1
>            Reporter: Jason Rutherglen
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1618.patch, MemoryCachedDirectory.java
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Add an IndexWriter.setDocStoreDirectory method that allows doc
> stores to be placed in a different directory than the IW default
> dir.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to