[ https://issues.apache.org/jira/browse/LUCENE-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711185#action_12711185 ]
Michael McCandless commented on LUCENE-1645: -------------------------------------------- bq. IFF the subreader being cloned is not readonly! OK. {quote} Hey, let's reverse readonly/writeable reader inheritance? WriteableSegmentReader extends SegmentReader. SegmentReader is readonly by behaviour and in code - there are no syncs and mutator methods throw UOE. WriteableSegmentReader adds a writeability layer over SegmentReader and all the gory syncs. {quote} That sounds right, but let's do this as a separate issue? And leave this issue on fixing this particular bug. {quote} Hey, open a new IR if you want to write. Cloning/reopening an IR while simultaneously switching readonly flag is a feature that gives user zero new functionality, absolutely nothing he can't accomplish using a new IR, but makes reopening/cloning code more complex. {quote} Opening a new IR is quite a bit more costly than cloning/reopening. Plus the reopen/cloning code will still need the complexity because internal to Lucene we still need to do this. We are only discussing whether the functionality should remain public, which I think it should. > Deleted documents are visible across reopened MSRs > -------------------------------------------------- > > Key: LUCENE-1645 > URL: https://issues.apache.org/jira/browse/LUCENE-1645 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 2.9 > Reporter: Earwin Burrfoot > Fix For: 2.9 > > Attachments: LUCENE-1645.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org