[ 
https://issues.apache.org/jira/browse/LUCENE-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712671#action_12712671
 ] 

Uwe Schindler commented on LUCENE-1636:
---------------------------------------

bq. A good example of this 'abuse' is in ShingleMatrixFilter.java in one of 
it's constructors.

This class extends TokenStream not TokenFilter! As the input instance member of 
TokenFilter is now final, it would not even compile. Please note, this is one 
of the contrib packages, not yet using the new API, so with useNewApi set to 
true, this TokenStream would fail (see LUCENE-1460). The change, you have the 
problem with, is caused by the new TokenStream API, and so NULL delegates are 
not possible!

> TokenFilters with a null value in the constructor fail
> ------------------------------------------------------
>
>                 Key: LUCENE-1636
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1636
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9
>            Reporter: Wouter Heijke
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: LUCENE-1636.patch
>
>
> While migrating from 2.4.x to 2.9-dev I found a lot of failing unittests.
> One problem is with TokenFilters that do a super(null) in the constructor.
> I fixed it by changing the constructor to super(new EmptyTokenStream())
> This will cause problems and frustration to others while migrating to 2.9.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to