[
https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714949#action_12714949
]
Michael McCandless commented on LUCENE-1658:
--------------------------------------------
I'm seeing this failure:
{quote}
[junit] Testcase:
testIndexInputMethods(org.apache.lucene.store.TestMMapDirectory): FAILED
[junit] FSDirectory has method public org.apache.lucene.store.IndexInput
org.apache.lucene.store.FSDirectory.openInput(java.lang.String) throws
java.io.IOException but MMapDirectory does not override
[junit] junit.framework.AssertionFailedError: FSDirectory has method public
org.apache.lucene.store.IndexInput
org.apache.lucene.store.FSDirectory.openInput(java.lang.String) throws
java.io.IOException but MMapDirectory does not override
[junit] at
org.apache.lucene.store.TestMMapDirectory.testIndexInputMethods(TestMMapDirectory.java:43)
[junit] at
org.apache.lucene.util.LuceneTestCase.runTest(LuceneTestCase.java:88)
{quote}
I think we should fix the test to make an exception...
> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>
> Key: LUCENE-1658
> URL: https://issues.apache.org/jira/browse/LUCENE-1658
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1658-take2.patch, LUCENE-1658-take2.patch,
> LUCENE-1658-take3.patch, LUCENE-1658-take3.patch, LUCENE-1658-take3.patch,
> LUCENE-1658-take3.patch, LUCENE-1658.patch, LUCENE-1658.patch,
> LUCENE-1658.patch
>
>
> I think whether one uses java.io.* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory. It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
