[ https://issues.apache.org/jira/browse/LUCENE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717660#action_12717660 ]
Uwe Schindler commented on LUCENE-1453: --------------------------------------- Both patches are the same, the second one is just using FSDir.open() instead of FSDir.getDirectory. For committing, I would use getDirectory(), the first patch. FSDir.open() would change behaviour for uses relying on the System property to specify the directory impl. > When reopen returns a new IndexReader, both IndexReaders may now control the > lifecycle of the underlying Directory which is managed by reference counting > --------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-1453 > URL: https://issues.apache.org/jira/browse/LUCENE-1453 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 2.4 > Reporter: Mark Miller > Assignee: Michael McCandless > Priority: Minor > Fix For: 2.4.1, 2.9 > > Attachments: Failing-testcase-LUCENE-1453.patch, > LUCENE-1453-with-FSDir-open.patch, LUCENE-1453.patch, LUCENE-1453.patch, > LUCENE-1453.patch, LUCENE-1453.patch > > > Rough summary. Basically, FSDirectory tracks references to FSDirectory and > when IndexReader.reopen shares a Directory with a created IndexReader and > closeDirectory is true, FSDirectory's ref management will see two decrements > for one increment. You can end up getting an AlreadyClosed exception on the > Directory when the IndexReader is open. > I have a test I'll put up. A solution seems fairly straightforward (at least > in what needs to be accomplished). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org