[ 
https://issues.apache.org/jira/browse/LUCENE-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725985#action_12725985
 ] 

Simon Willnauer commented on LUCENE-1722:
-----------------------------------------

bq. In my opinion, things such as Utility class and everything in .hhmm package 
should be package-protected. I already wasted time partially javadocing these 
things, which probably wasn't a complete waste, but you get the idea.
Yeah those could be cleaned up quite a bit. Lets do this in a different patch / 
issue after this one is commited.

bq. I think in the short term, I like this patch as is because I think 
developers will be able to port it to the new API and users will be able to 
understand what it does.
Lets get it in, it is a huge improvement to the Chinese documentation and 
needed too.


bq. I can come back around later and do a more thorough job, but this isn't the 
only analyzer that needs some documentation improvements!
Thanks for the attitude!

simon

> SmartChineseAnalyzer javadoc improvement
> ----------------------------------------
>
>                 Key: LUCENE-1722
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1722
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Simon Willnauer
>            Priority: Minor
>         Attachments: LUCENE-1722.txt
>
>
> Chinese -> English, and corrections to match reality (removes several javadoc 
> warnings)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to