[
https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731635#action_12731635
]
Simon Willnauer commented on LUCENE-1505:
-----------------------------------------
Hey Mike, thanks for taking this. I was too busy last week and I rather spent
time on Lucene-1566.
I looked at the patch - looks good to me. I wonder if it would make sense to do
some cleanup in the code (final vars and args etc.) and if we should remove
this logging code. It makes sense to use logging but afaik there is no ultimate
logging api in lucene so i would rather go for removing the logging code before
we release. Is that worth a new issue?!
simon
> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
> Key: LUCENE-1505
> URL: https://issues.apache.org/jira/browse/LUCENE-1505
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise
> it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
